feat(charm): add lipgloss styling with Slack brand colors under charm experiment by srtaalej · Pull Request #365 · slackapi/slack-cli

srtaalej · 2026-03-06T19:53:17Z

Changelog

Adds lipgloss-based styling to all help output under the charm experiment flag, using a centralized Slack brand color palette shared across all CLI components, and migrates all direct Styler() usage to named style functions.

Summary

This PR started as a focused effort to add lipgloss styling to help output, but grew in scope for two main reasons:

Charm v2 upgrade — Upgrading huh to v2 was necessary to fix bugs in the interactive forms related to styling. The v2 API introduced breaking changes to key press handling in tests (create_template_charm_test.go), requiring updates across all huh form test files.
Styler migration — To cleanly support both aurora (legacy) and lipgloss (charm) code paths, all external Styler() call sites were migrated to named style functions (Green(), Red(), Yellow(), Gray()). This touched many files but each change is mechanical.

The PR covers four logical areas:

chore(deps): Bump charm packages (huh, lipgloss) to v2
refactor: Migrate all Styler() call sites to named style functions
feat(experimental): Add Slack brand color palette (colors.go) and lipgloss style implementations
feat(experimental): Add charm-styled help page templates with flag colorization

Screenshots

Test steps

make test testdir=internal/style  # all tests pass (including new TestStyleFlags and TestStyleFlags_CharmDisabled)
make test testdir=cmd/help  # all tests pass
make build
./bin/slack --help -e charm  # flags show yellow names + gray descriptions, alias arrow uses ❱
./bin/slack project --help -e charm  # subcommand flags also styled (inherited help func)
./bin/slack run --help -e charm  # custom run help also styled (uses PrintHelpTemplate)
./bin/slack --help (no experiment)  # flags unchanged (plain text), arrow stays >
# Verify on both light and dark terminal backgrounds if possible

Known issues (follow-up)

Per reviewer feedback, these will be addressed in follow-up PRs:

Errors shown with green output (confusing to skim)
Section headings not contrasted with section text
Debug output loses highlighting when charm experiment is active

Code changes (to keep this PR from growing further):

Remove IsCharmEnabled() from internal/style and use
clients.Config.WithExperimentOn(experiment.Charm) checks outside the style package instead
(help.go:73, style.go:63). Deferred because it also requires changes to
cmd/platform/run.go.
Avoid renaming stable code for experimental changes — consider renaming charmHelpTemplate
back to helpTemplate when the experiment concludes (help.go:127)
Improve create_template_charm_test.go to assert expected values passed to huh forms
rather than testing prompt interactions directly

Requirements

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.

… experiment

codecov · 2026-03-06T19:56:45Z

Codecov Report

❌ Patch coverage is 73.07692% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.49%. Comparing base (9ab82a5) to head (cd2e287).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/style/template.go	8.33%	32 Missing and 1 partial ⚠️
internal/pkg/platform/activity.go	33.33%	4 Missing ⚠️
internal/iostreams/printer.go	25.00%	1 Missing and 2 partials ⚠️
cmd/help/help.go	50.00%	1 Missing and 1 partial ⚠️
cmd/manifest/validate.go	0.00%	2 Missing ⚠️
cmd/upgrade/upgrade.go	0.00%	2 Missing ⚠️
internal/style/style.go	97.75%	2 Missing ⚠️
internal/style/format.go	96.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   65.19%   65.49%   +0.29%     
==========================================
  Files         218      218              
  Lines       17981    18120     +139     
==========================================
+ Hits        11723    11867     +144     
+ Misses       5164     5160       -4     
+ Partials     1094     1093       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zimeg

@srtaalej Thanks for sharing these changes! I'm approving now in moon light so we might want to follow up with adjustments to the theme next 🌚

Some of these comments suggest that this PR should be broken up into perhaps multiple separate changes. No blocker since I think it's working alright but review might be more focused I hope - perhaps as: 🙏

chore(deps): update charm packages to v2
refactor: use style package for all stylings
feat(experimental): update branding and styles
feat(experimental): format help page outputs

Both 1 and 2 LGTM but I want to leave a few comments toward 3 then 4 next:

With a few test runs using the experiment I find that:

Errors are shown with green outputs which are confusing to skim I felt 👾
Section headings aren't contrasted with section text which make walls of text
Debug outputs lose highlighting after the experiment becomes active 🐛

Some related writings I find kind are clig.dev but we might find compromise in amount of formats for preference to theme. FWIW I find colors of the help pages helpful after patterns are gathered! Toward 4 we might want to consider the fang package for included batteries? 🔋 ⚡

Let's get this merged I think! The above can be discussed separate but needn't block experiment 🚢

internal/style/style_test.go

cmd/manifest/validate_test.go

zimeg · 2026-03-11T03:44:48Z

cmd/project/create_template_charm_test.go

 		// Navigate down to "View more samples" (4th option, index 3)
-		_, cmd := f.Update(tea.KeyMsg{Type: tea.KeyDown})
+		_, cmd := f.Update(tea.KeyPressMsg{Code: tea.KeyDown})
 		doAllUpdates(f, cmd)
-		_, cmd = f.Update(tea.KeyMsg{Type: tea.KeyDown})
+		_, cmd = f.Update(tea.KeyPressMsg{Code: tea.KeyDown})
 		doAllUpdates(f, cmd)
-		_, cmd = f.Update(tea.KeyMsg{Type: tea.KeyDown})
+		_, cmd = f.Update(tea.KeyPressMsg{Code: tea.KeyDown})
 		doAllUpdates(f, cmd)
-		_, cmd = f.Update(tea.KeyMsg{Type: tea.KeyEnter})
+		_, cmd = f.Update(tea.KeyPressMsg{Code: tea.KeyEnter})


🪬 thought: These changes aren't related to lipgloss which make review evermore difficult but also make me think we're testing too much related to prompts here. I'm not familiar with this implementation but I'd expect assertions that expected values are passed to huh forms?

these were updated to match the new v2 syntax for key presses - i agree this PR got really big really fast. i wanted to update to v2 here to resolve the bugs we had with the huh forms which i felt were related to styling. i just didnt realize there would be so much needing changing 😭

zimeg · 2026-03-11T03:49:14Z

cmd/help/help.go

+// ════════════════════════════════════════════════════════════════════════════════
+// DEPRECATED: Legacy help template — aurora styling
+//
+// Delete this entire block when the charm experiment is permanently enabled.
+// ════════════════════════════════════════════════════════════════════════════════
+
+const legacyHelpTemplate string = `{{.Long}}


🔍 suggestion: We should avoid changing existing code with experimental changes. I imagine we'll want to rename charmHelpTemplate back to helpTemplate after this experiment concludes, but references to stable code is being changed often during this. I'm not against moving code but it adds more to review!

cmd/upgrade/upgrade.go

zimeg · 2026-03-11T04:24:06Z

internal/pkg/apps/install_test.go

+		"non-breaking warning continues without prompt": {
+			warnings: slackerror.Warnings{
+				{Code: "some_warning", Message: "just a warning"},
+			},
+			expectedResult: true,
+		},


🧪 suggestion: While we're adding this we should confirm clients.IO.ConfirmPrompt isn't called in asserts below to match the test case. This might otherwise be prompting a default "no" to confirming changes of the manifest-

internal/style/colors.go

zimeg · 2026-03-11T04:36:42Z

internal/iostreams/printer.go

 		span, _ := opentracing.StartSpanFromContext(ctx, "printInfo", opentracing.Tag{Key: "printInfo", Value: message})
 		defer span.Finish()
 	}
-	io.Stdout.Println(style.Styler().Reset(message))


👁️‍🗨️ issue: I'm not super confident in this change to production code since this might've been guarding "info" output from being formatted in terminals as bold or secondary from previous lines.

We might continue to support this with exception for the charm experiment? I agree that it's not ideal to support edge cases of earlier output but it might keep experiences most stable.

internal/style/format.go

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

…tion panic

feat(charm): add lipgloss styling with Slack brand colors under charm…

0c3d9d6

… experiment

srtaalej added this to the Next Release milestone Mar 6, 2026

srtaalej self-assigned this Mar 6, 2026

srtaalej added experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment labels Mar 6, 2026

srtaalej mentioned this pull request Mar 9, 2026

feat(charm): adds 'huh' dynamic forms to create command #362

Merged

2 tasks

srtaalej added 3 commits March 10, 2026 11:42

Merge branch 'main' into charm-lipgloss-migration

e07ccae

update charm experiment to v2

6f4f50a

adaptive slack theme

f3f150d

srtaalej marked this pull request as ready for review March 10, 2026 17:48

srtaalej requested a review from a team as a code owner March 10, 2026 17:48

srtaalej marked this pull request as draft March 10, 2026 17:54

srtaalej and others added 5 commits March 10, 2026 13:58

tests for new lipgloss pkg

29b218e

build(deps): bump charm.land/huh/v2 from v2.0.1 to v2.0.3

3a5cc9f

update template format theme

faeb01c

tests

9dc0b88

Merge branch 'main' into charm-lipgloss-migration

be81b3d

srtaalej marked this pull request as ready for review March 11, 2026 00:02

mwbrooks added changelog Use on updates to be included in the release notes and removed changelog Use on updates to be included in the release notes labels Mar 11, 2026

zimeg approved these changes Mar 11, 2026

View reviewed changes

srtaalej and others added 8 commits March 11, 2026 11:40

Update internal/style/format.go

a440b11

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

Update cmd/manifest/validate_test.go

4f55cfc

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

fixes related to reviewer suggestions

14b9448

Merge branch 'main' into charm-lipgloss-migration

06d0233

fix: use typed empty Warnings in test mocks to prevent nil type asser…

9d08b0a

…tion panic

Merge branch 'main' into charm-lipgloss-migration

92b1bf4

fix: use typed empty Warnings in test mocks and run go mod tidy

6f4a9ab

Merge branch 'main' into charm-lipgloss-migration

cd2e287

srtaalej merged commit 755ccfe into main Mar 11, 2026
8 checks passed

srtaalej deleted the charm-lipgloss-migration branch March 11, 2026 17:33

This was referenced Mar 11, 2026

test(charm): clean up and consolidate charm tests #390

Merged

fix: address lipgloss styling gaps #391

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(charm): add lipgloss styling with Slack brand colors under charm experiment#365

feat(charm): add lipgloss styling with Slack brand colors under charm experiment#365
srtaalej merged 17 commits intomainfrom
charm-lipgloss-migration

srtaalej commented Mar 6, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

zimeg left a comment

Uh oh!

Uh oh!

Uh oh!

zimeg Mar 11, 2026

Uh oh!

srtaalej Mar 11, 2026

Uh oh!

zimeg Mar 11, 2026

Uh oh!

Uh oh!

zimeg Mar 11, 2026

Uh oh!

Uh oh!

Uh oh!

zimeg Mar 11, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

srtaalej commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Summary

Screenshots

Test steps

Known issues (follow-up)

Requirements

Uh oh!

codecov bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zimeg Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

srtaalej Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

zimeg Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zimeg Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zimeg Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

srtaalej commented Mar 6, 2026 •

edited

Loading

codecov bot commented Mar 6, 2026 •

edited

Loading